diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index ffef0173a4..38a28237c2 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,157 +1,398 @@ -# This configuration was generated by `rubocop --auto-gen-config` -# on 2014-08-19 13:06:13 +0200 using RuboCop version 0.25.0. +# This configuration was generated by +# `rubocop --auto-gen-config` +# on 2019-12-10 17:46:01 +0900 using RuboCop version 0.68.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. +# Offense count: 35 +# Cop supports --auto-correct. +# Configuration parameters: TreatCommentsAsGroupSeparators, Include. +# Include: **/*.gemfile, **/Gemfile, **/gems.rb Bundler/OrderedGems: - Enabled: false - + Exclude: + - 'Gemfile' + - 'gemfiles/rails_5.0.gemfile' + - 'gemfiles/rails_5.1.gemfile' + - 'gemfiles/rails_5.2.gemfile' + - 'gemfiles/rails_6.0.gemfile' + - 'spec/dummy_app/Gemfile' + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: TreatCommentsAsGroupSeparators, Include. +# Include: **/*.gemspec Gemspec/OrderedDependencies: - Enabled: false - -Gemspec/RequiredRubyVersion: - Enabled: false + Exclude: + - 'rails_admin.gemspec' +# Offense count: 2 +# Cop supports --auto-correct. Layout/ClosingHeredocIndentation: - Enabled: false + Exclude: + - 'lib/rails_admin/adapters/mongoid/abstract_object.rb' +# Offense count: 53 +# Cop supports --auto-correct. Layout/EmptyLineAfterGuardClause: Enabled: false +# Offense count: 5 +# Cop supports --auto-correct. Layout/EmptyLineAfterMagicComment: - Enabled: false - + Exclude: + - 'lib/rails_admin/support/csv_converter.rb' + - 'rails_admin.gemspec' + - 'spec/controllers/rails_admin/main_controller_spec.rb' + - 'spec/dummy_app/app/active_record/carrierwave_uploader.rb' + - 'spec/dummy_app/app/mongoid/carrierwave_uploader.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent Layout/IndentHeredoc: - Enabled: false + Exclude: + - 'lib/rails_admin/engine.rb' +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: Width, IgnoredPatterns. Layout/IndentationWidth: - Enabled: false + Exclude: + - 'lib/rails_admin/adapters/mongoid.rb' + - 'spec/spec_helper.rb' +# Offense count: 1 +# Cop supports --auto-correct. Layout/LeadingBlankLines: - Enabled: false + Exclude: + - 'lib/rails_admin/extension.rb' +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. +# SupportedStyles: space, no_space +# SupportedStylesForEmptyBraces: space, no_space Layout/SpaceBeforeBlockBraces: - Enabled: false + Exclude: + - 'spec/rails_admin/install_generator_spec.rb' +# Offense count: 1 Lint/AmbiguousBlockAssociation: - Enabled: false + Exclude: + - 'spec/rails_admin/install_generator_spec.rb' -# Offense count: 22 +# Offense count: 18 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: - Enabled: false - + Exclude: + - 'app/controllers/rails_admin/main_controller.rb' + - 'app/helpers/rails_admin/application_helper.rb' + - 'lib/rails_admin/abstract_model.rb' + - 'lib/rails_admin/adapters/active_record.rb' + - 'lib/rails_admin/config/actions/export.rb' + - 'lib/rails_admin/config/actions/index.rb' + - 'lib/rails_admin/config/actions/new.rb' + - 'lib/rails_admin/config/fields/factories/active_storage.rb' + - 'lib/rails_admin/config/fields/factories/association.rb' + - 'lib/rails_admin/config/fields/factories/carrierwave.rb' + - 'lib/rails_admin/config/fields/factories/devise.rb' + - 'lib/rails_admin/config/fields/factories/dragonfly.rb' + - 'lib/rails_admin/config/fields/factories/paperclip.rb' + - 'lib/rails_admin/config/fields/types/datetime.rb' + - 'spec/dummy_app/db/seeds.rb' + +# Offense count: 1 Lint/DuplicateMethods: - Enabled: false + Exclude: + - 'lib/rails_admin/config.rb' +# Offense count: 1 Lint/ReturnInVoidContext: - Enabled: false + Exclude: + - 'lib/rails_admin/support/csv_converter.rb' +# Offense count: 1 +# Cop supports --auto-correct. Lint/ScriptPermission: - Enabled: false + Exclude: + - 'spec/dummy_app/Rakefile' +# Offense count: 2 +# Cop supports --auto-correct. Lint/UnneededSplatExpansion: - Enabled: false + Exclude: + - 'spec/rails_admin/adapters/active_record/association_spec.rb' +# Offense count: 198 +# Configuration parameters: CountComments, ExcludedMethods. +# ExcludedMethods: refine Metrics/BlockLength: - Exclude: - - spec/**/*.rb - Max: 51 + Max: 1081 # Offense count: 7 Naming/AccessorMethodName: - Enabled: false - + Exclude: + - 'app/controllers/rails_admin/application_controller.rb' + - 'app/controllers/rails_admin/main_controller.rb' + - 'lib/rails_admin/abstract_model.rb' + - 'lib/rails_admin/adapters/active_record/abstract_object.rb' + +# Offense count: 6 +# Configuration parameters: Blacklist. +# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$)) Naming/HeredocDelimiterNaming: - Enabled: false - + Exclude: + - 'app/controllers/rails_admin/main_controller.rb' + - 'lib/rails_admin/adapters/mongoid.rb' + - 'lib/rails_admin/config/fields/base.rb' + - 'lib/rails_admin/engine.rb' + - 'lib/rails_admin/extensions/paper_trail/auditing_adapter.rb' + - 'spec/factories.rb' + +# Offense count: 2 +# Configuration parameters: EnforcedStyleForLeadingUnderscores. +# SupportedStylesForLeadingUnderscores: disallowed, required, optional Naming/MemoizedInstanceVariableName: - Enabled: false + Exclude: + - 'app/controllers/rails_admin/application_controller.rb' + - 'lib/rails_admin/config/has_description.rb' +# Offense count: 3 +# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. +# AllowedNames: io, id, to, by, on, in, at, ip, db Naming/UncommunicativeMethodParamName: - Enabled: false + Exclude: + - 'lib/rails_admin/abstract_model.rb' + - 'lib/rails_admin/config/model.rb' + - 'spec/rails_admin/adapters/mongoid/property_spec.rb' +# Offense count: 1 +# Configuration parameters: EnforcedStyle. +# SupportedStyles: snake_case, normalcase, non_integer Naming/VariableNumber: - Enabled: false + Exclude: + - 'spec/helpers/rails_admin/application_helper_spec.rb' # Offense count: 11 Style/ClassVars: - Enabled: false + Exclude: + - 'lib/rails_admin/abstract_model.rb' + - 'lib/rails_admin/config.rb' + - 'lib/rails_admin/config/actions.rb' + - 'lib/rails_admin/config/fields.rb' + - 'lib/rails_admin/config/fields/types.rb' +# Offense count: 1 Style/CommentedKeyword: - Enabled: false - -Style/ExpandPathArguments: - Enabled: false + Exclude: + - 'app/helpers/rails_admin/application_helper.rb' +# Offense count: 2 Style/EvalWithLocation: - Enabled: false + Exclude: + - 'lib/rails_admin/config/actions.rb' +# Offense count: 15 +# Cop supports --auto-correct. +Style/ExpandPathArguments: + Exclude: + - 'lib/generators/rails_admin/install_generator.rb' + - 'rails_admin.gemspec' + - 'spec/dummy_app/Rakefile' + - 'spec/dummy_app/config/application.rb' + - 'spec/dummy_app/config/boot.rb' + - 'spec/dummy_app/config/environment.rb' + - 'spec/integration/fields/multiple_carrierwave_spec.rb' + - 'spec/orm/active_record.rb' + - 'spec/rails_admin/active_record_extension_spec.rb' + - 'spec/rails_admin/install_generator_spec.rb' + - 'spec/spec_helper.rb' + +# Offense count: 9 +# Configuration parameters: MinBodyLength. Style/GuardClause: - Enabled: false - + Exclude: + - 'lib/rails_admin.rb' + - 'lib/rails_admin/adapters/active_record.rb' + - 'lib/rails_admin/bootstrap-sass.rb' + - 'lib/rails_admin/config.rb' + - 'lib/rails_admin/config/actions.rb' + - 'lib/rails_admin/config/fields/types/polymorphic_association.rb' + - 'lib/rails_admin/config/inspectable.rb' + - 'lib/rails_admin/config/sections/list.rb' + - 'lib/rails_admin/extension.rb' + +# Offense count: 2 Style/IdenticalConditionalBranches: - Enabled: false + Exclude: + - 'spec/integration/authorization/cancancan_spec.rb' +# Offense count: 17 +# Cop supports --auto-correct. Style/IfUnlessModifier: - Enabled: false - + Exclude: + - 'config/initializers/haml.rb' + - 'lib/rails_admin/adapters/active_record.rb' + - 'lib/rails_admin/adapters/mongoid.rb' + - 'lib/rails_admin/bootstrap-sass.rb' + - 'lib/rails_admin/config/actions/index.rb' + - 'lib/rails_admin/config/fields/types/active_storage.rb' + - 'lib/rails_admin/config/fields/types/multiple_active_storage.rb' + - 'lib/rails_admin/config/inspectable.rb' + - 'lib/rails_admin/extension.rb' + - 'lib/rails_admin/extensions/history/history.rb' + - 'lib/rails_admin/extensions/pundit/authorization_adapter.rb' + - 'lib/rails_admin/support/csv_converter.rb' + +# Offense count: 3 +# Cop supports --auto-correct. +# Configuration parameters: InverseMethods, InverseBlocks. Style/InverseMethods: - Enabled: false + Exclude: + - 'lib/rails_admin/config/fields.rb' + - 'lib/rails_admin/config/fields/types/enum.rb' + - 'lib/rails_admin/config/fields/types/polymorphic_association.rb' +# Offense count: 4 Style/MethodMissingSuper: - Enabled: false - -Style/MixinUsage: - Enabled: false + Exclude: + - 'lib/rails_admin/adapters/active_record/abstract_object.rb' + - 'lib/rails_admin/config/lazy_model.rb' + - 'lib/rails_admin/config/model.rb' + - 'lib/rails_admin/config/proxyable/proxy.rb' +# Offense count: 4 Style/MissingRespondToMissing: - Enabled: false + Exclude: + - 'lib/rails_admin/adapters/active_record/abstract_object.rb' + - 'lib/rails_admin/config/lazy_model.rb' + - 'lib/rails_admin/config/model.rb' + - 'lib/rails_admin/config/proxyable/proxy.rb' -Style/MultilineIfModifier: - Enabled: false +# Offense count: 2 +Style/MixinUsage: + Exclude: + - 'spec/controllers/rails_admin/main_controller_spec.rb' +# Offense count: 14 +# Cop supports --auto-correct. +Style/MultilineIfModifier: + Exclude: + - 'app/helpers/rails_admin/main_helper.rb' + - 'lib/rails_admin/extensions/pundit/authorization_adapter.rb' + - 'spec/controllers/rails_admin/main_controller_spec.rb' + - 'spec/integration/fields/action_text_spec.rb' + - 'spec/rails_admin/config/fields/types/action_text_spec.rb' + - 'spec/rails_admin/config/fields/types/active_storage_spec.rb' + - 'spec/rails_admin/config/fields/types/file_upload_spec.rb' + - 'spec/rails_admin/config/fields/types/multiple_active_storage_spec.rb' + - 'spec/rails_admin/config/fields/types/multiple_file_upload_spec.rb' + - 'spec/rails_admin/config/fields/types/shrine_spec.rb' + - 'spec/rails_admin/config_spec.rb' + +# Offense count: 1 Style/MultipleComparison: - Enabled: false + Exclude: + - 'lib/rails_admin/abstract_model.rb' +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods. +# SupportedStyles: predicate, comparison Style/NumericPredicate: - Enabled: false + Exclude: + - 'spec/**/*' + - 'lib/rails_admin/config.rb' + - 'lib/rails_admin/config/fields/types/string.rb' +# Offense count: 1 +# Cop supports --auto-correct. Style/OrAssignment: - Enabled: false + Exclude: + - 'lib/rails_admin/config/sections.rb' +# Offense count: 70 +# Cop supports --auto-correct. +# Configuration parameters: PreferredDelimiters. Style/PercentLiteralDelimiters: Enabled: false +# Offense count: 1 +# Cop supports --auto-correct. Style/RedundantSelf: - Enabled: false + Exclude: + - 'lib/rails_admin/config/fields/base.rb' # Offense count: 7 +# Cop supports --auto-correct. Style/RescueModifier: - Enabled: false - + Exclude: + - 'app/helpers/rails_admin/application_helper.rb' + - 'lib/rails_admin/abstract_model.rb' + - 'lib/rails_admin/adapters/mongoid/association.rb' + - 'lib/rails_admin/config/actions/show_in_app.rb' + - 'lib/rails_admin/extensions/paper_trail/auditing_adapter.rb' + +# Offense count: 3 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: implicit, explicit Style/RescueStandardError: - Enabled: false - -Style/SafeNavigation: - Enabled: false + Exclude: + - 'lib/rails_admin/adapters/mongoid.rb' + - 'lib/rails_admin/adapters/mongoid/bson.rb' + - 'lib/rails_admin/support/i18n.rb' +# Offense count: 1 +# Cop supports --auto-correct. Style/StderrPuts: - Enabled: false + Exclude: + - 'Rakefile' +# Offense count: 528 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. +# SupportedStyles: single_quotes, double_quotes Style/StringLiterals: Enabled: false +# Offense count: 93 +# Cop supports --auto-correct. +# Configuration parameters: . +# SupportedStyles: percent, brackets Style/SymbolArray: - Enabled: false + EnforcedStyle: percent + MinSize: 12 +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, AllowSafeAssignment. +# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex Style/TernaryParentheses: - Enabled: false + Exclude: + - 'spec/spec_helper.rb' +# Offense count: 10 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, MinSize, WordRegex. +# SupportedStyles: percent, brackets Style/WordArray: - Enabled: false - + Exclude: + - 'lib/rails_admin/adapters/active_record.rb' + - 'lib/rails_admin/support/datetime.rb' + - 'lib/rails_admin/support/i18n.rb' + - 'spec/rails_admin/abstract_model_spec.rb' + - 'spec/rails_admin/adapters/active_record_spec.rb' + +# Offense count: 4 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: forbid_for_all_comparison_operators, forbid_for_equality_operators_only, require_for_all_comparison_operators, require_for_equality_operators_only Style/YodaCondition: - Enabled: false + Exclude: + - 'lib/rails_admin/config/fields/base.rb' + - 'lib/rails_admin/config/hideable.rb' + - 'lib/tasks/rails_admin.rake'