-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why isn't webpack_compile_output enabled by default? #2312
Comments
Seeing how many 👍's #955 (comment) has, I think the users have spoken. Can someone create a PR?
A different aspect of this that I am keen to revisit is #1834 by @yvbeek. I think
|
@jakeNiemiec just created this simple pr to add this modifications. Let me know if anything else is needed... |
LGTM @LuanGB. Let's see what the maintainers have to say. |
@jakeNiemiec @LuanGB are you guys using TypeScript with Webpacker? Perhaps we can turn it back on for non-TypeScript projects? If this is causing issues for a lot of people, please do set it to |
No
This only sets the default. We want users who are inexperienced with webpacker to have easy access to errors. With #955, #2143 (comment), #2276, and others in mind, it seems like a better idea to default this to Annoying errors are better to have than silent errors. (and are easier to fix!) |
I've just been banging my head at webpacker not injecting my imported CSS in rails 6. Enabling this option and restarting seems to have solved it. Might I ask what the advantage to having it off is? |
I set it to true, but still don't get any log output? |
How you doing guys.
I was wondering why isn't
webpack_compile_output
enabled by default. If webpack fails to compile your bundles you won't see anything unless you enable it. Compiling issues are so commonplace when working on code or deploying that it doesn't make sense to me to have all webpack output stripped out by default.Would you guys consider having
webpack_compile_output
enabled by default? I think most people would benefit from that. Of course some devs may not want to see all the webpack output every time they do a change and refresh the browser, but they can always disable it.The text was updated successfully, but these errors were encountered: