Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why isn't webpack_compile_output enabled by default? #2312

Closed
kevinnio opened this issue Oct 3, 2019 · 7 comments · Fixed by #2316
Closed

Why isn't webpack_compile_output enabled by default? #2312

kevinnio opened this issue Oct 3, 2019 · 7 comments · Fixed by #2316

Comments

@kevinnio
Copy link

kevinnio commented Oct 3, 2019

How you doing guys.

I was wondering why isn't webpack_compile_output enabled by default. If webpack fails to compile your bundles you won't see anything unless you enable it. Compiling issues are so commonplace when working on code or deploying that it doesn't make sense to me to have all webpack output stripped out by default.

Would you guys consider having webpack_compile_output enabled by default? I think most people would benefit from that. Of course some devs may not want to see all the webpack output every time they do a change and refresh the browser, but they can always disable it.

@jakeNiemiec
Copy link
Member

Seeing how many 👍's #955 (comment) has, I think the users have spoken. Can someone create a PR?

webpack_compile_output: false


A different aspect of this that I am keen to revisit is #1834 by @yvbeek. I think errorDetails should also be true by default when in development:

errorDetails: false,

@LuanGB
Copy link
Contributor

LuanGB commented Oct 7, 2019

@jakeNiemiec just created this simple pr to add this modifications. Let me know if anything else is needed...

@kevinnio
Copy link
Author

kevinnio commented Oct 7, 2019

LGTM @LuanGB. Let's see what the maintainers have to say.

@yvbeek
Copy link
Contributor

yvbeek commented Oct 8, 2019

@jakeNiemiec @LuanGB are you guys using TypeScript with Webpacker?
It just seems to output so much info when errorDetails is true

Perhaps we can turn it back on for non-TypeScript projects?
Or can we somehow reduce the output to only the actual errors, not all that plugin noise?

If this is causing issues for a lot of people, please do set it to true by default.
However it would be nice to reduce all that output to useful information.

@jakeNiemiec
Copy link
Member

jakeNiemiec commented Oct 8, 2019

@yvbeek are you guys using TypeScript with Webpacker?

No

Or can we somehow reduce the output to only the actual errors, not all that plugin noise?

modules is still false in the PR, so this should not be an issue.

It just seems to output so much info when errorDetails is true

This only sets the default. We want users who are inexperienced with webpacker to have easy access to errors. With #955, #2143 (comment), #2276, and others in mind, it seems like a better idea to default this to true for new installs. You can always change this in your webpacker.yml.

Annoying errors are better to have than silent errors. (and are easier to fix!)

@Air-Craft
Copy link

I've just been banging my head at webpacker not injecting my imported CSS in rails 6. Enabling this option and restarting seems to have solved it. Might I ask what the advantage to having it off is?

@h0jeZvgoxFepBQ2C
Copy link

I set it to true, but still don't get any log output?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants