Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to terser-webpack-plugin for JS minification #1719

Closed
renchap opened this issue Oct 1, 2018 · 3 comments
Closed

Switch to terser-webpack-plugin for JS minification #1719

renchap opened this issue Oct 1, 2018 · 3 comments

Comments

@renchap
Copy link
Contributor

renchap commented Oct 1, 2018

UglifyJS2 (also known as uglify-es, which supports ES6) is no longer maintained. It has been forked into Terser and webpack replaced uglifyjs-webpack-plugin with it for Webpack 5: webpack/webpack#8036

I suggest that Webpacker switches to Terser as well as the currently user Uglify version has many unfixed bugs (especially when using ES6 output).

@renchap renchap changed the title Switch toterser-webpack-plugin Switch to terser-webpack-plugin for JS minification Oct 1, 2018
@bjankord
Copy link

bjankord commented Nov 7, 2018

I'd encourage the webpacker team to switch over to terser as well. The react team has identified that uglify-es breaks the new React build (16.6) due to bugs in uglify-es (and that uglify-es seems deprecated). So you probably want to get off that package.

@gauravtiwari
Copy link
Member

Please feel free to make a PR :)

@bjankord
Copy link

bjankord commented Dec 3, 2018

This is resolved with this PR: #1816
The PR has been merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants