Do not gzip assets that are already gzipped #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@byroot sprockets 3 don't gzip the assets anymore, so it will only affect 2.x. |
|
Awesome! |
| @@ -139,7 +139,9 @@ def stale?(environment) | |||
| # Save asset to disk. | |||
| def write_to(filename, options = {}) | |||
| # Gzip contents if filename has '.gz' | |||
| options[:compress] ||= File.extname(filename) == '.gz' | |||
There was a problem hiding this comment.
By the way I think there was a bug here. You couldn't pass compress: false
|
I had this same bug before, so I think it makes sense. |
rafaelfranca
added a commit
that referenced
this pull request
Jun 26, 2015
Do not gzip assets that are already gzipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know it's not really the vanilla use case for sprockets, but we were using it to serve a few
tar.gzarchives.Turns out sprockets would gzip them a second time :/
@josh do you think that fix make sense? I can also take a look at the 3.x branch to see if it's also affected.
cc @ryanbalsdon for discovering the bug.