Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.4 compatibility #99

Closed
tom-lord opened this issue Jan 5, 2017 · 4 comments
Closed

Ruby 2.4 compatibility #99

tom-lord opened this issue Jan 5, 2017 · 4 comments

Comments

@tom-lord
Copy link

tom-lord commented Jan 5, 2017

In case anyone else encounters this issue too...

Version 0.4.2 of this gem relies on json ~> 1.7, which resolves to v1.8.3 - as defined in this line.

However, the json v1.8.3 gem is not compatible with ruby 2.4.

This issue was resolved in this gem here, by changing the gem's dependencies.

However, since v1.0.0 of this gem has not yet been released, in order to use this gem within a ruby 2.4 project you must currently place something like this in your Gemfile:

group :doc do
  gem 'sdoc', '1.0.0.rc1', require: false
end
@zzak
Copy link
Member

zzak commented Mar 6, 2017

Thank you @tom-lord! I will make a final release 🔜!!

@stoivo
Copy link

stoivo commented Apr 19, 2017

How soon?

@tom-lord
Copy link
Author

tom-lord commented Jun 8, 2017

This is less of an issue now since json v1.8.5 was released (after I raised this issue), which adds support for ruby 2.4.

In the issue linked above, the gem maintainers originally stated that compatibility for ruby 2.4 would not be added for json 1.8.x, then later changed their minds.

@tom-lord
Copy link
Author

tom-lord commented Jun 8, 2017

...So I'll close this issue now, but it would still be good to see a v1.0.0 release!

@tom-lord tom-lord closed this as completed Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants