Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly added files that are already digested aren't available in development #139

Closed
joker-777 opened this issue May 29, 2023 · 4 comments · Fixed by #144
Closed

Newly added files that are already digested aren't available in development #139

joker-777 opened this issue May 29, 2023 · 4 comments · Fixed by #144

Comments

@joker-777
Copy link
Contributor

Hi, we have a couple of assets that we don't want propshaft to digest and therefore we add the predigested suffix to its file name. This worked until the new version 0.7.0. This pull request introduced changes that broke this feature. It doesn't add new assets with the digested suffix the load_path (only the first found asset).
The problem is that in this line asset.logical_path is always filename.js and not filename-xyz.digested.js. This is because in this line it removes the predigested part from the logical path.

@brenogazzola
Copy link
Collaborator

I've been considering reverting that one. Quick question: how are those files being created? Are they esbuild chunks?

@joker-777
Copy link
Contributor Author

No, they are created with webpack. If I find some time later I can try to find a fix and create a PR for it.

@joker-777
Copy link
Contributor Author

@brenogazzola I created a little PR. I didn't test it yet though.

@joker-777
Copy link
Contributor Author

@brenogazzola Just fixed the specs of my little PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants