Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serving JS files from /vendor is insecure #275

Closed
thisismydesign opened this issue Oct 24, 2024 · 1 comment
Closed

Serving JS files from /vendor is insecure #275

thisismydesign opened this issue Oct 24, 2024 · 1 comment

Comments

@thisismydesign
Copy link

thisismydesign commented Oct 24, 2024

I think nothing is stopping me from creating a commit in a project that says 'Update react' and making arbitrary changes to vendor/javascript/react.js. The change is impossible to review and AFAICT nothing is checking the integrity of this file. At least I could modify the file in my project and the modified file was simply served.

Related: #122 and #199

@dhh
Copy link
Member

dhh commented Nov 12, 2024

Guarding your code base against developers who have access to it is not a threat model we're interested in pursuing.

@dhh dhh closed this as completed Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants