Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importmap pin/update removes preload: false #243

Closed
mhenrixon opened this issue Feb 8, 2024 · 1 comment
Closed

importmap pin/update removes preload: false #243

mhenrixon opened this issue Feb 8, 2024 · 1 comment

Comments

@mhenrixon
Copy link

mhenrixon commented Feb 8, 2024

When I run importmap pin @turbo-boost/commands it changes the importmaps.rb line from:

pin "@turbo-boost/commands", to: "@turbo-boost--commands.js", preload: false # @0.0.16

To:

pin "@turbo-boost/commands", to: "@turbo-boost--commands.js" # @0.0.16

I believe that it should keep any existing preload: false

@dhh
Copy link
Member

dhh commented Oct 25, 2024

There's no such guarantee of persistence when using the pin command. It's a fine line here, but we can't and won't turn this into a full-blown package manager, so going to call this out of scope at the moment.

@dhh dhh closed this as completed Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants