Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple importmaps #240

Open
manuelmeurer opened this issue Jan 28, 2024 · 6 comments
Open

Multiple importmaps #240

manuelmeurer opened this issue Jan 28, 2024 · 6 comments

Comments

@manuelmeurer
Copy link

Maybe I'm missing something, but shouldn't it be possible to have multiple separate importmaps? :)

My app has three distinct parts/namespaces ("web" for the public marketing page, "admin" for the admin area, and "clients" for the login area for clients) and for each I'd like to have different pinned (and preloaded) modules.

Right now I'm solving it by keeping three different Importmap::Maps around and delegating Rails.application.importmap to Current.importmap, which loads the correct importmap for the current namespace, but that seems to be much more complicated than it should be.

I'm sure I'm not the only one that has multiple distinct namespaces in their app? :)
Is there another way to solve this?

Happy to have a stab at implementing this if it's a welcomed feature.

@deanpcmad
Copy link

I'd also like to see this. Would be very useful for splitting up public/admin JS

@manuelmeurer
Copy link
Author

@deanpcmad Feel free to use my fork/branch as described in the PR for now: #241
I use it in production and it works great!

@sarmad90
Copy link

sarmad90 commented Feb 1, 2024

@manuelmeurer that's great. Let me know if you need any help in completing the PR. I would be happy to help.

@sarmad90
Copy link

sarmad90 commented Feb 1, 2024

@manuelmeurer I have added some comments on the PR.

@aseroff
Copy link
Contributor

aseroff commented Mar 14, 2024

I +1 the need for this.
An approach I was considering taking is keeping a single importmap (since having unnecessary pins doesn't make a significant difference), but changing the pin's preload based on the provided import module tag.

To illustrate: javascript_importmap_tags expands to the importmap, the preloads, and the initial module import defined by the provided entry_point parameter. If we passed the entry_point parameter to javascript_importmap_module_preload_tags, we could enable the preloading to be defined by something like pin 'admin', preload: [:admin] in config/importmap.rb. The result would accomplish the desired result without having to maintain multiple importmaps.

If this seems agreeable I could throw a PR together.

@jimhj
Copy link

jimhj commented May 14, 2024

Definitely need this.
any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants