Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong opcodes for some operations #2

Open
Cl0v1s opened this issue Nov 9, 2023 · 1 comment
Open

Wrong opcodes for some operations #2

Cl0v1s opened this issue Nov 9, 2023 · 1 comment

Comments

@Cl0v1s
Copy link

Cl0v1s commented Nov 9, 2023

Hi ! First of all, thanks for your work on this JS assembler :)

I noticed that a few opcodes aren't correctly assembled when we use the produced binary code in the latest UXN VM.
In particular, NIP, SWP, ROT, DUP and OVR seem off.

I used this file as reference and noticed that the opcodes were wrong: https://git.sr.ht/~rabbits/uxn5/tree/1c0890e51a13ab737222c714770f664e90ad9260/item/src/uxn.js#L155

I fixed that in my own project with this commit. Will probably make a PR soon !

Cl0v1s/vscode-uxn-exec@29f7773#diff-35c17f92b3ed6cfe078f9a5b184f4c224343424ff178f2dde24161794edfbaa4

@rafapaezbas
Copy link
Owner

Thank you very much for the info, I am a little bit behind in the project, I guess those op codes have changed for the recently. I will have to change the tests too.

Greetings and thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants