New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

context is not cancelled when ListenAndServe returns error #15

Closed

raeperd opened this issue Oct 20, 2024 · 0 comments · Fixed by #16

Assignees

Labels

bug

Owner

raeperd commented Oct 20, 2024

Must cancel context properly for error returned by http.ListenAndServe

kickstart.go/main.go

Lines 59 to 65 in d0d0a2c

    
           go func() { 
        
           	slog.InfoContext(ctx, "server started", slog.String("addr", server.Addr)) 
        
           	if err := server.ListenAndServe(); err != nil && err != http.ErrServerClosed { 
        
           		slog.ErrorContext(ctx, "server error", slog.Any("error", err)) 
        
           	} 
        
           }() 
        
           <-ctx.Done()

Thanks to

https://www.reddit.com/r/golang/comments/1g7s7so/comment/lstv943/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button

raeperd added a commit that referenced this issue


          fix: Fix shutdown error handling #15

0a7d666

raeperd mentioned this issue

fix: Fix shutdown error handling #15 #16

Merged

raeperd added a commit that referenced this issue


          fix: Fix shutdown error handling #15

9f75cd6

raeperd closed this as completed in #16

raeperd self-assigned this

raeperd added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment