Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCADS specific code in comm should be moved into scalaengine #40

Open
rxin opened this issue Nov 14, 2010 · 2 comments
Open

SCADS specific code in comm should be moved into scalaengine #40

rxin opened this issue Nov 14, 2010 · 2 comments

Comments

@rxin
Copy link
Member

rxin commented Nov 14, 2010

My understanding is that the comm folder provides the infrastructure for messaging support.

Most stuff in Messages.scala are really only relevant to SCADS-engine. They should probably be moved into engine.

@marmbrus
Copy link
Member

while i agree with this idea in principle, its going to require a fair amount of refactoring. Right now the message handler is hard coded to accept a certain set of messages. This is why these messages are defined in comm and not scalaengine.

@stephentu
Copy link
Member

another reason that messages are defined in comm is due to issues w/ the typer, which is a limitation of the scala compiler plugin framework (messages defined in the same compliation pass are typechecked before the auto-generated methods are added, but we need the typer to run before we can auto-generate methods).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants