-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update React Native installation instructions #236
Comments
That change is not in the released version yet. In few days I guess... |
The change is included in the newly released 0.18-rc (I haven't tested it with redux 4 yet), so hopefully not long to go! |
OK, I got There are couple of steps need to be done which I hide them at the moment in
There is a discussion here facebook/react-native#2985 (comment) which @spicyj talks about changing fbjs. Also @gaearon I still need to remove all .babelrc files under node_modules before I can run the example-react-native-redux. What is your suggestion? |
Before checking anything I just replaced import { Provider } from 'react-redux/native';
...
<Provider store={store}>
{() => <App/>}
</Provider>
TO:
import { Provider } from 'react-redux';
...
<Provider store={store}>
<App/>
</Provider> I use the most recent version of
I didn't need to change anything in the |
In npm 2.x, if you define peerDependencies, it will install it in your root node_modules. |
Maybe if we make |
@spicyj That's an interesting idea. Making react a peer dep sounds like it could be semantically correct. I think it's probably more correct that fbjs is a normal dependency though, and RN 0.19 may address the issue with conflicting fbjs modules with some patches that are being reviewed. (Alternatively npm3 fixes this too.) |
@alinz I use npm@3 |
@Purii That should be it, since |
@Purii thanks. your method works perfectly for me with npm@3 |
It works for me with npm@3 |
I think it's safer to modify the instructions if/after |
Send a PR? Should be pretty simple. |
For those here looking for a solution for |
The fbjs commits didn't make it into 0.19 so stay tuned for 0.20 or 0.21. |
To be fair, the problems at this point that result from using [email protected] and react-redux@4 are entirely bugs within the dependency resolver the react-native bundle operation performs. They are in no way unique to react-redux. They do go away with npm@3; because, it no longer has the duplicate dependencies. |
@zuk @alinz How did it work for you guys?
I'm using NPM3 with these dependencies:
I don't have |
Yes, you’d need to depend on |
@gaearon Thanks Dan, looks like it's working :) But, now I get a different error:
Which seems there's no solution yet :( |
Unfortunately I can’t really help you with this! Hopefully this will be fixed. |
Yeah I know it's not related to this repo, just ranting 😞 |
@ranyefet we do have my npm version is 3.6.0 |
Thanks @alinz upgrading Node to 5.5 appear to fixed other issues I had, weird! |
So, what's going on? Are we still waiting for react-native to be a peer of react? |
If anyone encountered same problems, here is a way worth to try:
with a refreshed install and see if it works |
Yes. AFAIK it is already the case in master. Just waiting for the next release. |
Good! But wasn't it included in 0.20? @gaearon do you recommend reinstalling the modules to make it work right now? |
Still appears to be a dependency in 0.20: https://github.com/facebook/react-native/blob/6496feb61e9205baa3f25cf448c4fce912bd6250/package.json#L136 cc @skevy |
@gaearon working on it :) We'll know by Friday if "React as as a peer dep" is going to make it into the 0.21-RC branch cut. Thanks for the ping. Trust me, we're working hard to get this stuff worked out and make React Native a better member of the general React ecosystem. |
I have no doubts about your efforts, thank you very much for working on this! |
The note in README now says you can use |
…test Added test for shallowEqualScalar in connect decorator
Seems that React Native works on top of react already. the issue facebook/react-native#2985 is already closed.
Can we already use React-Redux 4?
The text was updated successfully, but these errors were encountered: