Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normal vs default attribute #171

Closed
phoolish opened this issue Nov 11, 2015 · 8 comments
Closed

normal vs default attribute #171

phoolish opened this issue Nov 11, 2015 · 8 comments

Comments

@phoolish
Copy link
Contributor

Why is a normal attribute used vs a default attribute on https://github.com/rackspace-cookbooks/elkstack/blob/master/attributes/logstash.rb#L2 ? Is this due to an upstream cookbook?

@martinb3
Copy link
Contributor

Yes, at the time it was due to the upstream cookbook.

@martinb3
Copy link
Contributor

There's some major releases pending in elasticsearch (the cookbook) tied to v2.0.0 of Elasticsearch (the software project), but then I'd like to do a big refactor of elkstack to catch it up to the new versions.

@phoolish
Copy link
Contributor Author

That sounds great. I'd be interested in assisting (especially with the logstash integration) as we use this cookbook pretty extensively in our setup.

@martinb3
Copy link
Contributor

@phoolish That would be wonderful! Honestly, we could start any time.

@martinb3
Copy link
Contributor

I think we're looking at:
https://github.com/elastic/cookbook-elasticsearch/tree/2.0.0_wip (will be merged to master)
https://github.com/lusis/chef-logstash (master as of now)
https://github.com/lusis/chef-kibana (master as of now)

So I'm thinking we'd bump to those, and then refactor.

@phoolish
Copy link
Contributor Author

That makes sense. Could you also elaborate on #136?

@martinb3
Copy link
Contributor

@phoolish I tried to update that. At it's core, it's basically "refactor" so we are doing the interesting work around E, L, and K but not necessarily write custom implementations of things like SSL certificates.

@phoolish
Copy link
Contributor Author

Seems like the right approach. I'll get started tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants