Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent behaviour with checker and create-text #33

Open
bremner opened this issue Jan 26, 2019 · 1 comment
Open

inconsistent behaviour with checker and create-text #33

bremner opened this issue Jan 26, 2019 · 1 comment

Comments

@bremner
Copy link

bremner commented Jan 26, 2019

I'm not sure if this is intended, but it's confusing, at least to me.

I have

(define allow-submit-on-error?  #t)

in info.rkt. When I submit files that fail user defined checks (in this case a missing identifier), the text version is written as expected. When I submit files with lines longer than maxwidth, the grading directory is not created and the text version of the file is not written.

I don't completely understand the code, but it looks like the width check happens earlier than user defined checks. It's not like it's terribly hard for students to meet the line length constraints, but if it is a harder constraint it would be good to document, so admins don't get confused into thinking no text versions at all are being created on errors.

@elibarzilay
Copy link
Member

I vaguely remember the maximum width thing being implemented at the level that converts the wxme file into text, so that error is probably taken as other conversion errors and therefore no text version is made. It would probably be easy to avoid that error when the parameter is on, but I'm guessing that you'll want something in the file that indicates it rather than just ignoring it (otherwise you could turn the width checking off) -- and that's probably more involved...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants