Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Definitions export from management UI does not include vhost metadata #10515

Closed
lukebakken opened this issue Feb 7, 2024 · 3 comments · Fixed by #11538 · May be fixed by #10539
Closed

Definitions export from management UI does not include vhost metadata #10515

lukebakken opened this issue Feb 7, 2024 · 3 comments · Fixed by #11538 · May be fixed by #10539
Assignees
@michaelklishin @lukebakken
Labels
bug
Milestone
3.13.4

Comments

@lukebakken
Copy link
Collaborator

lukebakken commented Feb 7, 2024 •
edited
Loading

https://vmware.slack.com/archives/C0RDGG81Z/p1707224857559109

Reproduction steps:

Create vhost

rabbitmqctl add_vhost test --default-queue-type quorum

Export using CLI

rabbitmqctl export_definitions test-vhost-with-queue-type-from-cli.json

Note that the above file includes vhost metadata:

    "vhosts": [
        {
            "limits": [],
            "metadata": {
                "description": "Default virtual host",
                "tags": []
            },
            "name": "/"
        },
        {
            "limits": [],
            "metadata": {
                "description": "",
                "tags": [],
                "default_queue_type": "quorum"
            },
            "name": "test"
        }
    ],

Export using management UI

Note that the exported file does NOT contain metadata:

    "vhosts": [
        {
            "name": "/"
        },
        {
            "name": "test"
        }
    ],
@lukebakken lukebakken added the bug label Feb 7, 2024
@lukebakken lukebakken mentioned this issue Feb 7, 2024
Open
@michaelklishin
Copy link
Member

@lukebakken thank you for digging in and providing the details.

@lukebakken
Copy link
Collaborator Author

cc @pvladMQ

michaelklishin added a commit that referenced this issue Feb 12, 2024
@michaelklishin
Definition export: include virtual host metadata
2ca0648 
when exporting over the HTTP API. CLI tools
use rabbit_definitions:all_definitions/0 which
already include the metadata.

Closes #10515
@michaelklishin michaelklishin mentioned this issue Feb 12, 2024
Draft
michaelklishin added a commit that referenced this issue Feb 12, 2024
@michaelklishin
Add a test (assertion) for #10515
1f7c6a0
michaelklishin added a commit that referenced this issue Feb 13, 2024
@michaelklishin
Definition export: include virtual host metadata
64227ba 
when exporting over the HTTP API. CLI tools
use rabbit_definitions:all_definitions/0 which
already include the metadata.

Closes #10515
This was referenced Jun 7, 2024
Closed
Closed
@michaelklishin michaelklishin added this to the 3.13.4 milestone Jun 23, 2024
@michaelklishin michaelklishin mentioned this issue Jun 23, 2024
Merged
@michaelklishin
Copy link
Member

#11538 addresses the essential part of it. Virtual host limits are not considered to be, well, virtual host parameters by the HTTP API and the internally used schema database. They are runtime parameters.

So I think #11538 is an acceptable solution, at least for now.

mergify bot pushed a commit that referenced this issue Jun 23, 2024
@michaelklishin @mergify
GET /api/definitions now returns virtual host metadata
733c363 
Closes #10515.
References #11454.

(cherry picked from commit aa466d2)
@mergify mergify bot mentioned this issue Jun 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelklishin michaelklishin

@lukebakken lukebakken

Labels
bug
Projects
None yet
Milestone
3.13.4
2 participants
@michaelklishin @lukebakken