Skip to content

Commit 8817682

Browse files
committed
Adapt naming strategy changes to 2.x branch
References #513
1 parent 8c26ebd commit 8817682

File tree

4 files changed

+22
-18
lines changed

4 files changed

+22
-18
lines changed

src/main/java/com/rabbitmq/jms/admin/NamingStrategy.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
* <p>A custom implementation can be used to customize the name of some entities (e.g. for security
1212
* reasons), but implementators must be prepared to API changes.
1313
*
14-
* @since 3.4.0
14+
* @since 2.11.0
1515
* @see RMQConnectionFactory#setNamingStrategy(NamingStrategy)
1616
*/
1717
public interface NamingStrategy extends Serializable {

src/main/java/com/rabbitmq/jms/admin/RMQConnectionFactory.java

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1224,22 +1224,23 @@ public void setValidateSubscriptionNames(boolean validateSubscriptionNames) {
12241224
this.validateSubscriptionNames = validateSubscriptionNames;
12251225
}
12261226

1227-
/**
1228-
* Naming strategy for AMQP entities.
1229-
*
1230-
* <p>Most applications should not worry about this setting, the default is fine.
1231-
*
1232-
* <p>Note {@link NamingStrategy} is not considered a public and stable API.
1233-
*
1234-
* @param namingStrategy naming strategy
1235-
* @see NamingStrategy
1236-
*/
1237-
public void setNamingStrategy(NamingStrategy namingStrategy) {
1238-
if (namingStrategy == null) {
1239-
throw new IllegalArgumentException("Naming strategy cannot be null");
1240-
}
1241-
this.namingStrategy = namingStrategy;
1227+
/**
1228+
* Naming strategy for AMQP entities.
1229+
*
1230+
* <p>Most applications should not worry about this setting, the default is fine.
1231+
*
1232+
* <p>Note {@link NamingStrategy} is not considered a public and stable API.
1233+
*
1234+
* @param namingStrategy naming strategy
1235+
* @see NamingStrategy
1236+
* @since 2.11.0
1237+
*/
1238+
public void setNamingStrategy(NamingStrategy namingStrategy) {
1239+
if (namingStrategy == null) {
1240+
throw new IllegalArgumentException("Naming strategy cannot be null");
12421241
}
1242+
this.namingStrategy = namingStrategy;
1243+
}
12431244

12441245
@FunctionalInterface
12451246
private interface ConnectionCreator {

src/test/java/com/rabbitmq/TestUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ public interface ExceptionBooleanSupplier {
150150

151151
}
152152

153-
public static Connection amqpConnection(jakarta.jms.Connection connection) {
153+
public static Connection amqpConnection(javax.jms.Connection connection) {
154154
try {
155155
Field connectionField = RMQConnection.class.getDeclaredField("rabbitConnection");
156156
connectionField.setAccessible(true);

src/test/java/com/rabbitmq/integration/tests/NamingStrategyIT.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,14 @@
77
import com.rabbitmq.client.Channel;
88
import com.rabbitmq.jms.admin.NamingStrategy;
99
import com.rabbitmq.jms.admin.RMQConnectionFactory;
10-
import jakarta.jms.*;
1110
import java.io.IOException;
1211
import java.lang.reflect.Proxy;
1312
import java.util.Set;
1413
import java.util.concurrent.ConcurrentHashMap;
14+
import javax.jms.Connection;
15+
import javax.jms.MessageConsumer;
16+
import javax.jms.Session;
17+
import javax.jms.Topic;
1518
import org.junit.jupiter.api.AfterEach;
1619
import org.junit.jupiter.api.BeforeEach;
1720
import org.junit.jupiter.api.Test;

0 commit comments

Comments
 (0)