Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection Recovery is triggered without the old connection being closed #1767

Closed
JanEggers opened this issue Jan 10, 2025 · 4 comments
Closed
Labels

Comments

@JanEggers
Copy link
Contributor

Describe the bug

I recently updated 6.8.1 to 7.0.0 and now im seeing massive reconnects without the old connection beeing closed in the broker.
In normal operations we use about 200 connections that are statically allocated so connection churn should be 0. when I look at the dashboard I see massive number of connections and growing.

image

image

I see this behavior after some time of running the app in a testenvironment but I was not yet able to narrow down the cause of the behavior. I hooked into the events on connection and see logs that connections are recovered. but I dont see any indication why reconnect was initiated.

Reproduction steps

x

Expected behavior

connection recovery should not inflate the number of open connections.

Additional context

No response

@JanEggers JanEggers added the bug label Jan 10, 2025
@JanEggers
Copy link
Contributor Author

looks like connection recovery was just a sideeffect of the many connections created by AspNetCore.HealthChecks.Rabbitmq will continue to investigate

@JanEggers
Copy link
Contributor Author

confirmed they dont close the connection sry for bothering you

@lukebakken
Copy link
Contributor

lukebakken commented Jan 10, 2025

sry for bothering you

No problem, thanks for following up here.

It sounds like the AspNetCore.HealthChecks.Rabbitmq could use some work.

I wonder if you hit this? Xabaril/AspNetCore.Diagnostics.HealthChecks#2343

@JanEggers
Copy link
Contributor Author

https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/blob/6f0275257fde28a4d0e30808fd21ebf661fe9177/src/HealthChecks.Rabbitmq/RabbitMQHealthCheck.cs#L31-L35

basically the code just works for the singleton case in case the factory is used it leaks connections im in the process of creating a bug there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants