Skip to content

unable to change user's import secret #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KyriosGN0 opened this issue Jan 1, 2025 · 3 comments
Open

unable to change user's import secret #924

KyriosGN0 opened this issue Jan 1, 2025 · 3 comments

Comments

@KyriosGN0
Copy link

Describe the bug

when changing the name of the import secret in a user CR, the message topology update doesn't update the user itself

To Reproduce

Steps to reproduce the behavior:

  1. create a user with a import secret (our name was -user-credentials)
  2. create a new secret with a required password and username fields
  3. change the import secret param in the user cr
  4. try to login with the new user, fails

image
Expected behavior
rmq will use the password in the new secret

Version and environment information

  • Messaging Topology Operator: [1.15.0]
  • RabbitMQ: [e.g. 3.13.7]
  • RabbitMQ Cluster Operator: [1.15.0]
  • Kubernetes: [1.30.0]
  • Cloud provider or hardware configuration: GKE

Additional context

the new secret had more fields then required if that's a problem

@KyriosGN0 KyriosGN0 added the bug Something isn't working label Jan 1, 2025
Copy link

github-actions bot commented Mar 3, 2025

This issue has been marked as stale due to 60 days of inactivity. Stale issues will be closed after a further 30 days of inactivity; please remove the stale label in order to prevent this occurring.

@github-actions github-actions bot added the stale label Mar 3, 2025
@KyriosGN0
Copy link
Author

not stale

@Zerpet
Copy link
Member

Zerpet commented Mar 13, 2025

This is working as intended. Perhaps not ideal, but as intended. See this answer for more details of what happens internally #571 (comment)

In order to support secret updates, the Operator would have to compare the information from the Secret with the current state inside RabbitMQ to take the adequate action. What is adequate when the username changes? RabbitMQ does not support username updates, shall the operator delete the user and create a new one? This can have many implications, and possibly open room for exploit.

@Zerpet Zerpet removed the bug Something isn't working label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants