Skip to content

Conversation

@coro
Copy link
Contributor

@coro coro commented Feb 9, 2022

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Additional Context

The 'grep' command in the test had incorrectly escaped quote characters.

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

Copy link
Member

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder how this ever worked 🙈

@coro coro merged commit e5cabe8 into main Feb 9, 2022
@coro coro deleted the fix-vault-ci branch February 9, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants