edit workflow to add support for ppc64le image generation #1421
Conversation
Zerpet
left a comment
Zerpet
left a comment
There was a problem hiding this comment.
Thank you for contributing to the cluster operator! The changes are in the right direction. I left a comment to remove two steps that won't be necessary.
| - name: OCI Metadata for single-arch ppc64le image | ||
| #if: startsWith(github.ref, 'refs/tags/v') | ||
| id: single-arch-meta-ppc64le | ||
| uses: docker/metadata-action@v4 | ||
| with: | ||
| # list of Docker images to use as base name for tags | ||
| images: | | ||
| rabbitmqoperator/cluster-operator | ||
| flavor: | | ||
| latest=false | ||
| # generate Docker tags based on the following events/attributes | ||
| tags: | | ||
| type=semver,pattern={{version}},suffix=-ppc64le,latest=false | ||
| type=sha,suffix=-ppc64le,latest=false | ||
| - name: Build and push single-arch ppc64le image | ||
| #if: startsWith(github.ref, 'refs/tags/v') | ||
| uses: docker/build-push-action@v3 | ||
| with: | ||
| context: . | ||
| platforms: linux/ppc64le | ||
| push: ${{ github.event_name != 'pull_request' }} | ||
| tags: ${{ steps.single-arch-meta-ppc64le.outputs.tags }} | ||
| labels: ${{ steps.single-arch-meta-ppc64le.outputs.labels }} |
There was a problem hiding this comment.
We don't need a special case for single-arch image for ppc64. The other single-arch image cases are to workaround a limitation from one of our internal processes. The ppc64 arch won't flow as part of that internal process, so this case won't be needed
There was a problem hiding this comment.
@Zerpet Noted and removed single arch image case for ppc64le
|
CI fails because the fork doesn't have access to the repo secrets. The Operator builds fine, and that should be enough. The entire pipeline will run after merging. |
|
Thank you! |
|
@Zerpet when is your next release planned so we can avoid using sha value docker pull |
|
There's not much to release a new minor yet v2.4.0...main Probably after summer. |
2 participants
This closes #1419
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
This PR edits github actions workflow and add support to generate ppc64le image along with amd64 and arm64.
Additional Context
None
Local Testing
Please ensure you run the unit, integration and system tests before approving the PR.
To run the unit and integration tests:
You will need to target a k8s cluster and have the operator deployed for running the system tests.
For example, for a Kubernetes context named
dev-bunny: