adding support for MinReadySeconds in statefulsetspec #1179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #
https://app.zenhub.com/workspaces/service-operator-experience-623895d9b17eb7001156689f/issues/rabbitmq/service-operator-experience/143
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
Adding the possibility to override the field minimumReadySeconds in the statefulsetspec
Additional Context
This feature seems not to be enabled by default in K8s < 1.25 but we need to setup --feature-gates=StatefulSetMinReadySeconds=true
This can be done with minikube in this way: minikube start --cpus 12 --memory 12000 --feature-gates=StatefulSetMinReadySeconds=true
Local Testing
Please ensure you run the unit, integration and system tests before approving the PR.
To run the unit and integration tests:
You will need to target a k8s cluster and have the operator deployed for running the system tests.
For example, for a Kubernetes context named
dev-bunny: