Skip to content

Conversation

@DanielePalaia
Copy link
Contributor

This closes #

https://app.zenhub.com/workspaces/service-operator-experience-623895d9b17eb7001156689f/issues/rabbitmq/service-operator-experience/143

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

Adding the possibility to override the field minimumReadySeconds in the statefulsetspec

Additional Context

This feature seems not to be enabled by default in K8s < 1.25 but we need to setup --feature-gates=StatefulSetMinReadySeconds=true

This can be done with minikube in this way: minikube start --cpus 12 --memory 12000 --feature-gates=StatefulSetMinReadySeconds=true

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

@DanielePalaia DanielePalaia force-pushed the MinReadySeconds_implementation branch from d8c4c91 to 07be207 Compare November 4, 2022 10:11
@DanielePalaia DanielePalaia force-pushed the MinReadySeconds_implementation branch from 07be207 to 0e0fc23 Compare November 4, 2022 10:15
@DanielePalaia DanielePalaia merged commit bbc913d into main Nov 7, 2022
@DanielePalaia DanielePalaia deleted the MinReadySeconds_implementation branch November 9, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants