Skip to content

Conversation

@coro
Copy link
Contributor

@coro coro commented Aug 23, 2022

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

Removes the image restriction on the JSON logging example, since all supported versions of RabbitMQ are now valid for this particular documented example.

Additional Context

The CI testing this example was failing since the image 3.9.4-management is no longer compatible with the operator.

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

@ChunyiLyu ChunyiLyu merged commit 16ee94f into main Aug 23, 2022
@ChunyiLyu ChunyiLyu deleted the json-log-example branch August 23, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants