Skip to content

Conversation

@ChunyiLyu
Copy link
Contributor

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

  • extract operator defaults to a separate func to keep Reconciler shorter and more concise
  • extract operator defaults controller tests to dedicated test unit as well
  • use updateRabbitmqCluster() since the update logic is shared for updating these operator defaults

Additional Context

Local Testing

Tested in integration controller tests suite

- to keep Reconciler shorter and more concise
@ChunyiLyu ChunyiLyu requested a review from coro June 14, 2022 14:03
@ChunyiLyu ChunyiLyu merged commit f2ab5ce into main Jun 14, 2022
@ChunyiLyu ChunyiLyu deleted the reconciler-refactors branch June 14, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants