Skip to content

Conversation

@jiuker
Copy link
Contributor

@jiuker jiuker commented Jun 9, 2022

This closes #

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

Additional Context

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

Wrap all error

Copy link
Member

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I will squash merge shortly.

@Zerpet
Copy link
Member

Zerpet commented Jun 13, 2022

The error in GitHub Actions is caused by a regression in RabbitMQ master. It is ok to merge.

@Zerpet Zerpet merged commit 6d5295b into rabbitmq:main Jun 13, 2022
@jiuker jiuker deleted the wrap_error branch June 13, 2022 09:32
@jiuker jiuker restored the wrap_error branch June 13, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants