Update Ginkgo to V2 #1011
Merged
Update Ginkgo to V2 #1011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
System tests seem to be a bit flaky in Actions. System tests run fine locally. |
Member
Author
|
Right so "resolve conflicts" button merges the main branch into the feature branch 🤦♂️ I'll resolve them locally and force push. |
Two significant changes affected our code base: 1. The table DSL i.e. `DescribeTable` and `Entry` have been moved to top-level. It was not required to import `extensions/table` anymore 1. Changes to CLI flag arguments to randomise all specs There was a function name conflict because our code base and Ginkgo define the function `Label()`. Due to the dot-import, it caused a name conflict. This was resolved by aliasing our module. Disabled metrics in integration tests to avoid MacOS firewall popup everytime we run integration tests. We do not observe or scrape metrics in the integration tests at the moment. In the future, we could bind to localhost if needed. Small refactor on getting the configuration to use a library function, instead of a home-made one. Signed-off-by: Aitor Perez Cedres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary Of Changes
Two significant changes affected our code base:
DescribeTableandEntryhave been moved totop-level. It was not required to import
extensions/tableanymoreThere was a function name conflict because our code base and Ginkgo
define the function
Label(). Due to the dot-import, it caused a nameconflict. This was resolved by aliasing our module.
Disabled metrics in integration tests to avoid MacOS firewall popup
everytime we run integration tests. We do not observe or scrape metrics
in the integration tests at the moment. In the future, we could bind to
localhost if needed.
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Additional Context
Unit and integration tests are green.
Local Testing
Please ensure you run the unit, integration and system tests before approving the PR.
To run the unit and integration tests:
You will need to target a k8s cluster and have the operator deployed for running the system tests.
For example, for a Kubernetes context named
dev-bunny: