[CI] Remove replace version in OLM

The current logic is brittle, and it is guaranteed to break after we
release 2.10.0.

The problem with `ls -1v` is that it lists in alphabetical order, not
in semver order. That means that a list with 2.1.0, 2.9.0, 2.10.0 and
2.11.0 would be listed as:

2.1.0
2.10.0
2.11.0
2.9.0

The previous logic would always yield 2.9.0 (bottom) as the replace
version. That is not correct for 2.11.0.

The opm validator does not complain by not providing a "replaces"
version, so it may just be fine and OLM may have some magic sauce to
figure out what version to upgrade to.

[skip ci]

Author: Zerpet

.github/workflows/testing_and_publishing_OLM_bundle.yml

@@ -189,7 +189,7 @@ jobs:
         name: Publish on OperatorHub and Openshift marketplace
         runs-on: ubuntu-latest
         needs: test-olm-package
-#        if: ${{ startsWith(github.ref, 'refs/tags/v') }}
+        if: ${{ startsWith(github.ref, 'refs/tags/v') }}
         steps:
         - name: Checkout community-operators fork (OperatorHub)
           uses: actions/checkout@v4
@@ -215,9 +215,7 @@ jobs:
             git branch rabbitmq-cluster-operator-$BUNDLE_VERSION
             git checkout rabbitmq-cluster-operator-$BUNDLE_VERSION
 
-            REPLACE_VERSION=$(ls -1v | tail -2 | head -1)
             cp -v -fR olm-package-ci/"$BUNDLE_VERSION" ./operators/rabbitmq-cluster-operator/
-            sed -i -e "s/replaces: null/replaces: rabbitmq-cluster-operator.v$REPLACE_VERSION/g" ./operators/rabbitmq-cluster-operator/$BUNDLE_VERSION/manifests/rabbitmq.clusterserviceversion.yaml
             sed -i -e "s/latest/$BUNDLE_VERSION/g" ./operators/rabbitmq-cluster-operator/$BUNDLE_VERSION/manifests/rabbitmq.clusterserviceversion.yaml
             git add operators/rabbitmq-cluster-operator
             git commit -s -m "RabbitMQ Operator release $BUNDLE_VERSION"
@@ -253,9 +251,7 @@ jobs:
             git branch rabbitmq-cluster-operator-$BUNDLE_VERSION
             git checkout rabbitmq-cluster-operator-$BUNDLE_VERSION
 
-            REPLACE_VERSION=$(ls -1v | tail -2 | head -1)
             cp -v -fR olm-package-ci/"$BUNDLE_VERSION-openshift" ./operators/rabbitmq-cluster-operator/"$BUNDLE_VERSION"
-            sed -i -e "s/replaces: null/replaces: rabbitmq-cluster-operator.v$REPLACE_VERSION/g" ./operators/rabbitmq-cluster-operator/"$BUNDLE_VERSION"/manifests/rabbitmq.clusterserviceversion.yaml
             sed -i -e "s/latest/$BUNDLE_VERSION/g" ./operators/rabbitmq-cluster-operator/"$BUNDLE_VERSION"/manifests/rabbitmq.clusterserviceversion.yaml
             git add operators/rabbitmq-cluster-operator
             git commit -s -m "RabbitMQ Operator release $BUNDLE_VERSION"

scripts/print-tag-version.bash

@@ -5,4 +5,4 @@ if [ "$GITHUB_REF_TYPE" != "tag" ]; then
   exit 0
 fi
 
-printf "BUNDLE_VERSION=%s\n" "$GITHUB_REF_NAME"
+printf "BUNDLE_VERSION=%s\n" "${GITHUB_REF_NAME:1}"