Skip to content

Commit ba02159

Browse files
committed
Remove ineffective test
This test became ineffective after #1735. We want to enable Web MQTT/STOMP TLS regardless of whether a CA bundle certificate is provided. This test was asserting that we enable web stomp/mqqt tls when the CA bundle is set; however, by not setting the CA bundle, the test passes anyway. This is not correct, making the test ineffective.
1 parent aa72d5d commit ba02159

File tree

1 file changed

+0
-22
lines changed

1 file changed

+0
-22
lines changed

internal/resource/statefulset_test.go

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -621,28 +621,6 @@ var _ = Describe("StatefulSet", func() {
621621
}))
622622
})
623623

624-
When("Mutual TLS (same secret) is enabled", func() {
625-
It("opens tls ports when rabbitmq_web_mqtt and rabbitmq_web_stomp are configured", func() {
626-
instance.Spec.TLS.SecretName = "tls-secret"
627-
instance.Spec.TLS.CaSecretName = "tls-secret"
628-
instance.Spec.Rabbitmq.AdditionalPlugins = []rabbitmqv1beta1.Plugin{"rabbitmq_web_mqtt", "rabbitmq_web_stomp"}
629-
Expect(stsBuilder.Update(statefulSet)).To(Succeed())
630-
631-
rabbitmqContainerSpec := extractContainer(statefulSet.Spec.Template.Spec.Containers, "rabbitmq")
632-
633-
Expect(rabbitmqContainerSpec.Ports).To(ContainElements([]corev1.ContainerPort{
634-
{
635-
Name: "web-mqtt-tls",
636-
ContainerPort: 15676,
637-
},
638-
{
639-
Name: "web-stomp-tls",
640-
ContainerPort: 15673,
641-
},
642-
}))
643-
})
644-
})
645-
646624
When("Mutual TLS (different secret) is enabled", func() {
647625
It("adds the CA cert secret to tls project volume", func() {
648626
instance.Spec.TLS.SecretName = "tls-secret"

0 commit comments

Comments
 (0)