Commit b6d9557
committed
Don't consider stderr CLI output to be an error
Between RabbitMQ v3.8.14 and v3.8.15, the command
`rabbitmq-queues rebalance quorum` outputs warn messages like
`10:59:50.674 [warn] Node :"[email protected]" only
contains 1 queues, do nothing` to stderr.
Although this CLI command exits with 0, the operator considers this as a
failure, retrying to execute that command. The operator logs the
following:
`2021-03-19T08:39:56.305Z ERROR
controller-runtime.manager.controller.rabbitmqcluster Reconciler error
{"reconciler group": "rabbitmq.com", "reconciler kind":
"RabbitmqCluster", "name": "r1", "namespace": "default", "error":
"failed to run queue rebalance on pod r1-server-0:`
In general when CLI commands output to stderr, it doesn't mean that
there was an error. So, in this commit we only consider non-zero exit
codes as error.1 parent 7117161 commit b6d9557
File tree
2 files changed
+3
-9
lines changed- config/crd/bases
- controllers
2 files changed
+3
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3499 | 3499 | | |
3500 | 3500 | | |
3501 | 3501 | | |
3502 | | - | |
| 3502 | + | |
3503 | 3503 | | |
3504 | 3504 | | |
3505 | 3505 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | 51 | | |
58 | | - | |
| 52 | + | |
59 | 53 | | |
0 commit comments