Skip to content

Commit 4c2df18

Browse files
authored
Add promtool for alert rule validation (#1824)
1 parent 4c790d4 commit 4c2df18

File tree

4 files changed

+268
-8
lines changed

4 files changed

+268
-8
lines changed

.github/workflows/prometheus-rules.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@ jobs:
3838
3939
- name: Check Prometheus rule file
4040
run: |
41-
# need to use @main because of https://github.com/prometheus/prometheus/issues/8586#issuecomment-796976710
42-
GO111MODULE=on go get github.com/prometheus/prometheus/cmd/promtool@main
41+
make install-tools
4342
promtool check rules observability/prometheus/rule-file.yml
4443
- name: Commit Prometheus rule file
4544
working-directory: observability/prometheus

internal/tools/go.mod

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ require (
2828
github.com/go-logr/logr v1.4.2 // indirect
2929
github.com/go-logr/zapr v1.3.0 // indirect
3030
github.com/go-openapi/jsonpointer v0.21.0 // indirect
31-
github.com/go-openapi/jsonreference v0.20.2 // indirect
31+
github.com/go-openapi/jsonreference v0.21.0 // indirect
3232
github.com/go-openapi/swag v0.23.0 // indirect
3333
github.com/go-task/slim-sprig/v3 v3.0.0 // indirect
3434
github.com/gobuffalo/flect v1.0.3 // indirect
@@ -57,6 +57,7 @@ require (
5757
github.com/monochromegane/go-gitignore v0.0.0-20200626010858-205db1a8cc00 // indirect
5858
github.com/pelletier/go-toml v1.9.5 // indirect
5959
github.com/pkg/errors v0.9.1 // indirect
60+
github.com/prometheus/prometheus v0.302.0 // indirect
6061
github.com/sergi/go-diff v1.2.0 // indirect
6162
github.com/spf13/afero v1.6.0 // indirect
6263
github.com/spf13/cobra v1.8.1 // indirect
@@ -65,16 +66,16 @@ require (
6566
github.com/xlab/treeprint v1.2.0 // indirect
6667
go.uber.org/multierr v1.11.0 // indirect
6768
go.uber.org/zap v1.27.0 // indirect
68-
golang.org/x/crypto v0.31.0 // indirect
69+
golang.org/x/crypto v0.32.0 // indirect
6970
golang.org/x/mod v0.22.0 // indirect
70-
golang.org/x/net v0.33.0 // indirect
71+
golang.org/x/net v0.34.0 // indirect
7172
golang.org/x/sync v0.10.0 // indirect
72-
golang.org/x/sys v0.28.0 // indirect
73+
golang.org/x/sys v0.29.0 // indirect
7374
golang.org/x/telemetry v0.0.0-20240522233618-39ace7a40ae7 // indirect
7475
golang.org/x/text v0.21.0 // indirect
75-
golang.org/x/tools v0.28.0 // indirect
76+
golang.org/x/tools v0.29.0 // indirect
7677
golang.org/x/xerrors v0.0.0-20231012003039-104605ab7028 // indirect
77-
google.golang.org/protobuf v1.36.1 // indirect
78+
google.golang.org/protobuf v1.36.4 // indirect
7879
gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect
7980
gopkg.in/inf.v0 v0.9.1 // indirect
8081
gopkg.in/yaml.v2 v2.4.0 // indirect

0 commit comments

Comments
 (0)