Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README not up to date #154

Closed
scriptcoded opened this issue Jan 18, 2023 · 3 comments
Closed

README not up to date #154

scriptcoded opened this issue Jan 18, 2023 · 3 comments
Assignees
@lukebakken
Milestone
1.6.0

Comments

@scriptcoded
Copy link
Contributor

The following section in the README

We expect this client to undergo moderate breaking public API changes in 2021. Major and minor versions will be updated accordingly.

says there will be breaking changes in 2021. It appears we're in 2023 now 🎉 I'm unaware of what these breaking changes are or if they're implemented, but perhaps the README should be revised 😄
@lukebakken
Copy link
Contributor

We welcome pull requests, even for small things like updating the README. Thanks.

@lukebakken lukebakken added this to the 1.6.0 milestone Jan 18, 2023
@lukebakken lukebakken self-assigned this Jan 18, 2023
@scriptcoded scriptcoded mentioned this issue Jan 18, 2023
Merged
@scriptcoded
Copy link
Contributor Author

@lukebakken Raised #155. Though as I said I'm not aware of what changes are being referred to. Seeing as the last tag here on GitHub is 1.1.0 from September 2021 I can only assume these changes have been made and the paragraph should simply be removed. Please tell me if this assumption is incorrect.

@lukebakken
Copy link
Contributor

Fixed by #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
2 participants
@lukebakken @scriptcoded