Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.automaticDimension for viewHeight of ViewFormer #109

Open
Gerz-inc opened this issue Apr 1, 2020 · 1 comment
Open

.automaticDimension for viewHeight of ViewFormer #109

Gerz-inc opened this issue Apr 1, 2020 · 1 comment

Comments

@Gerz-inc
Copy link

Gerz-inc commented Apr 1, 2020

Why you didn't use UITableView.automaticDimension as default value for viewHeight?

open class ViewFormer {
    
    // MARK: Public
    
    open var viewHeight: CGFloat = UITableView.automaticDimension // was 10

    .....
}
@ZacharyKhan
Copy link
Collaborator

This would definitely be a great improvement. Feel free to open a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants