Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing broken dependencies (lws, bandmat) on macOS 10.14 #159

Closed
TheButlah opened this issue Jun 26, 2019 · 6 comments
Closed

Fixing broken dependencies (lws, bandmat) on macOS 10.14 #159

TheButlah opened this issue Jun 26, 2019 · 6 comments
Assignees
Labels

Comments

@TheButlah
Copy link

TheButlah commented Jun 26, 2019

Hello,

I wanted to put this here as some friendly help for anyone else running into this issue on macOS 10.14. Initially, I was unable to get this code to work as installing lws as well as bandmat was not working.

I was able to solve the issue by compiling bandmat manually, as well as lws. However, lws was initially unable to compile as it appears to be broken on newer installs of Xcode. I have posted a workaround over at the lws repo here: Jonathan-LeRoux/lws#7 (comment). Follow those instructions to make a fix for your setup.py file, and then proceed to install lws from there.

After that, everything should (hopefully) work!

@alexiej
Copy link

alexiej commented Jul 3, 2019

Hi, I still got an error when I try to install nnmnkwii required for this package. Running setup.py install for bandmat ... error, but I installed from the source:
git clone git://github.com/MattShannon/bandmat.git python setup.py build_ext --inplace
finished correct, and the library works fine, but still, the pip installation for nnmnkwii try to download them from the internet.
@TheButlah : How you fix this?

@alexiej
Copy link

alexiej commented Jul 3, 2019

I finally found a working workaround. Below instructions for who like I spend hours to figure it out.

  1. Clone lws
https://github.com/Jonathan-LeRoux/lws.git
  1. Replace line 41 in the file python/setup.py with the above code
ext_modules = [Extension("lws",
                             sources=[lws_module_src,"lwslib/lwslib.cpp"],
                             include_dirs=["lwslib/",np.get_include()],
                             language="c++",
                             extra_compile_args=["-O3", "-stdlib=libc++"],
                             extra_link_args=["-stdlib=libc++"])],
  1. compile lws
cd lws/python
make sdist
pip install dist/lws-1.2.tar.gz
  1. clone bandmat
https://github.com/MattShannon/bandmat.git
  1. Create distribution and install bandmat
cd bandmat
python setup.py sdist
pip install dist/bandmat-0.8.dev1.tar.gz
  1. Try install nnmnkwii
pip install nnmnkwii

If everything works fine you can install wavenet_vocoder

pip install -e ".[train]"

or

pip install -e ".[test]"

@r9y9
Copy link
Owner

r9y9 commented Jul 6, 2019

I'm working on fixing the dependency problem. 1) I will remove lws dependency from the repo and use librosa instead. 2) I will make bandmat requirement optional for nnmnkwii (r9y9/nnmnkwii#88).

Ref: r9y9/deepvoice3_pytorch#154, MattShannon/bandmat#10

@r9y9
Copy link
Owner

r9y9 commented Jul 6, 2019

bandmat dependency is fixed now by r9y9/nnmnkwii#88. I will work on lws part afterwards.

@r9y9
Copy link
Owner

r9y9 commented Jul 6, 2019

By the way, my workaround for new osx versions is SeanNaren/warp-ctc#129 (comment).

@r9y9 r9y9 added the bug label Jul 6, 2019
@r9y9 r9y9 self-assigned this Jul 6, 2019
@TheButlah
Copy link
Author

TheButlah commented Jul 8, 2019

I've spoken with the LWS author and he has updated the code so that the pip package works now. I have tested it on the latest lws version, lws==1.2.3. No clue if bandmat still has issues or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants