vec_as_location(missing = "error") and logical NA

[krlmlr]

Should this fail?

vctrs::vec_as_location(NA, 3, missing = "error")
#> [1] NA NA NA

^{Created on 2021-07-30 by the reprex package (v2.0.0.9000)}

[DavisVaughan]

Hmm, probably. That would mean this should fail too:

vctrs::vec_as_location(NA_character_, 2, missing = "error", names = c("x", "y"))
#> [1] NA

lgl_as_location() and chr_as_location() don't check missing right now:

vctrs/src/subscript-loc.c

Line 219 in 81e3247

static SEXP lgl_as_location(SEXP subscript, R_len_t n,

vctrs/src/subscript-loc.c

Line 278 in 81e3247

static SEXP chr_as_location(SEXP subscript, SEXP names,