Merge pull request #1217 from r-lib/saf

Author: IndrajeetPatil

.lintr

@@ -14,6 +14,7 @@ linters: all_linters(
     todo_comment_linter = NULL,
     nonportable_path_linter = NULL,
     string_boundary_linter = NULL,
+    strings_as_factors_linter = NULL, # since we use R >= 4.0
     undesirable_function_linter = NULL,
     undesirable_operator_linter = NULL
   )

R/token-define.R

@@ -23,8 +23,7 @@ token <- rbind.data.frame(
   c("if",            "cond",           "IF"),
   c("else",          "cond",         "ELSE"),
   c("in",       "loop_cond",           "IN"),
-  c("while",    "loop_cond",        "WHILE"),
-  stringsAsFactors = FALSE
+  c("while",    "loop_cond",        "WHILE")
 )
 # styler: on
 

R/ui-caching.R

@@ -104,8 +104,7 @@ cache_info <- function(cache_name = NULL, format = "both") {
     last_modified = suppressWarnings(max(file_info$mtime)),
     created = file.info(path_cache)$ctime,
     location = path_cache,
-    activated = cache_is_activated(cache_name),
-    stringsAsFactors = FALSE
+    activated = cache_is_activated(cache_name)
   )
 
   if (any(c("lucid", "both") == format)) {

R/utils.R

@@ -44,15 +44,15 @@ re_match <- function(text, pattern) {
   end <- start + length - 1L
   matchstr <- substring(text, start, end)
   matchstr[start == -1L] <- NA_character_
-  res <- data.frame(stringsAsFactors = FALSE, .text = text, .match = matchstr)
+  res <- data.frame(.text = text, .match = matchstr)
 
   gstart <- attr(match, "capture.start")
   glength <- attr(match, "capture.length")
   gend <- gstart + glength - 1L
   groupstr <- substring(text, gstart, gend)
   groupstr[gstart == -1L] <- NA_character_
   dim(groupstr) <- dim(gstart)
-  res <- cbind(groupstr, res, stringsAsFactors = FALSE)
+  res <- cbind(groupstr, res)
 
   names(res) <- c(attr(match, "capture.names"), ".text", ".match")
   res