Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies arg for package_info() #22

Merged
merged 2 commits into from
Sep 25, 2018

Conversation

gaborcsardi
Copy link
Member

@gaborcsardi gaborcsardi commented Sep 24, 2018

To specify what kind of dependencies we want.

For the FALSE case, the output it not so minimal, now that we also print the lib path:

❯ package_info("cli",  dependencies = FALSE)
 package * version    date       lib source
 cli       1.0.0.9002 2018-09-22 [1] Github (r-lib/cli@f46ce3f)

[1] /Users/gaborcsardi/r_pkgs
[2] /Library/Frameworks/R.framework/Versions/3.5/Resources/library

Closes #21.

To specify what kind of dependencies we want to include. Closes #21.
@codecov-io
Copy link

codecov-io commented Sep 24, 2018

Codecov Report

Merging #22 into master will decrease coverage by 2.09%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #22     +/-   ##
=========================================
- Coverage   94.82%   92.73%   -2.1%     
=========================================
  Files           8        8             
  Lines         232      234      +2     
=========================================
- Hits          220      217      -3     
- Misses         12       17      +5
Impacted Files Coverage Δ
R/package-info.R 92.92% <100%> (ø) ⬆️
R/dependent-packages.R 87.75% <64.28%> (-10.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c89a5d0...014e377. Read the comment docs.

Copy link
Member

@jimhester jimhester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

character(0)
} else if (is.character(x)) {
x
dep_types_hard <- function() c("Depends", "Imports", "LinkingTo")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this needs to be a function rather than just a constant?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just trying to avoid non-function code in packages in general. Got bitten many times. But yeah, it could be a constant this time.

@gaborcsardi gaborcsardi merged commit c7b3eb1 into master Sep 25, 2018
@gaborcsardi
Copy link
Member Author

Thanks!

@gaborcsardi gaborcsardi deleted the feature/package-info-dependencies branch October 13, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants