-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependencies arg for package_info() #22
Conversation
To specify what kind of dependencies we want to include. Closes #21.
Codecov Report
@@ Coverage Diff @@
## master #22 +/- ##
=========================================
- Coverage 94.82% 92.73% -2.1%
=========================================
Files 8 8
Lines 232 234 +2
=========================================
- Hits 220 217 -3
- Misses 12 17 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
character(0) | ||
} else if (is.character(x)) { | ||
x | ||
dep_types_hard <- function() c("Depends", "Imports", "LinkingTo") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this needs to be a function rather than just a constant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just trying to avoid non-function code in packages in general. Got bitten many times. But yeah, it could be a constant this time.
Thanks! |
To specify what kind of dependencies we want.
For the
FALSE
case, the output it not so minimal, now that we also print the lib path:Closes #21.