Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not consult "max.print" option when printing platform or package info #13

Merged
merged 2 commits into from
Aug 9, 2018

Conversation

jennybc
Copy link
Member

@jennybc jennybc commented Aug 9, 2018

If user has set "max.print" to something modest, sessioninfo::session_info() can print output that is frustratingly truncated. The message can be quite mystifying, since "max.print" constrains entries, but the message about hidden info refers to rows.

Via slack, we agreed to set max to a very large value inside print.data.frame here.

Below we only see 2 rows-worth of package info because each row contains 4 items and 2 * 4 = 8 < 10.

options(max.print=10)
sessioninfo::session_info()
#> ─ Session info ──────────────────────────────────────────────────────────
#>  setting  value                       
#>  version  R version 3.5.1 (2018-07-02)
#>  os       macOS Sierra 10.12.6        
#>  system   x86_64, darwin15.6.0        
#>  ui       X11                         
#>  language (EN)                        
#>  [ reached getOption("max.print") -- omitted 3 rows ]
#> 
#> ─ Packages ──────────────────────────────────────────────────────────────
#>  package     * version date       source        
#>  backports     1.1.2   2017-12-13 CRAN (R 3.5.0)
#>  clisymbols    1.2.0   2017-05-21 cran (@1.2.0) 
#>  [ reached getOption("max.print") -- omitted 14 rows ]

@codecov-io
Copy link

codecov-io commented Aug 9, 2018

Codecov Report

Merging #13 into master will decrease coverage by 1.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage     100%   98.75%   -1.25%     
==========================================
  Files           8        8              
  Lines         180      161      -19     
==========================================
- Hits          180      159      -21     
- Misses          0        2       +2
Impacted Files Coverage Δ
R/package-info.R 100% <100%> (ø) ⬆️
R/platform-info.R 100% <100%> (ø) ⬆️
R/osname.R 80% <0%> (-20%) ⬇️
R/dependent-packages.R 97.67% <0%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c871d01...bda950b. Read the comment docs.

@gaborcsardi
Copy link
Member

Great, thanks much!

@gaborcsardi gaborcsardi merged commit 92c5943 into master Aug 9, 2018
@gaborcsardi gaborcsardi deleted the print-moar-lines branch October 13, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants