-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pak local install overwrites newer package version #662
Comments
That does not do anything for me. I cannot reproduce this: ❯ pak::pkg_install("r-lib/cli")
✔ Loading metadata database ... done
→ Will update 1 package.
→ The package (0 B) is cached.
+ cli 3.6.3 → 3.6.3.9000 👷🏿♀️🔧 (GitHub: d9febb5)
? Do you want to continue (Y/n)
ℹ No downloads are needed, 1 pkg is cached
✔ Got cli 3.6.3.9000 (source) (768.96 kB)
ℹ Packaging cli 3.6.3.9000
✔ Packaged cli 3.6.3.9000 (2.6s)
ℹ Building cli 3.6.3.9000
✔ Built cli 3.6.3.9000 (5.8s)
✔ Installed cli 3.6.3.9000 (github::r-lib/cli@d9febb5) (53ms)
✔ 1 pkg: upd 1, dld 1 (NA B) [16.1s] ❯ pak::pkg_install("local::.")
→ Will update 1 package.
→ The package (0 B) is cached.
+ rcmdcheck 1.4.0 → 1.4.0.9000 👷🏿♀️
? Do you want to continue (Y/n)
ℹ No downloads are needed, 1 pkg is cached
✔ Got rcmdcheck 1.4.0.9000 (source) (96 B)
ℹ Packaging rcmdcheck 1.4.0.9000
✔ Packaged rcmdcheck 1.4.0.9000 (540ms)
ℹ Building rcmdcheck 1.4.0.9000
✔ Built rcmdcheck 1.4.0.9000 (1.4s)
✔ Installed rcmdcheck 1.4.0.9000 (local) (24ms)
✔ 1 pkg + 14 deps: kept 14, upd 1, dld 1 (NA B) [4.5s] |
Is this what you are installing locally?
means that you want insight from GitHub, that last commit of the main branch. So that's what pak is installing. I understand that this is not ideal for local development, maybe pak should have another mode where local installs are accepted (although it is not easy to tell what is a local install). |
Ah, ok. That could explain it. Yes, I had this version installed, where I was locally working on: Than I wanted to install performance locally (the version from main, https://github.com/easystats/performance/), which downloaded and installed insight from main, despite having a lower version number. Maybe for |
Version numbers do not matter for a package from GitHub. Most people don't increase the version number for every commit, and it is impossible to have linear version numbers for multiple branches. You can remove the |
What do you mean by this? |
You have
in |
Yes, that's intended. insight is imported by performance and includes new features that I want to test for performance on GitHub |
Steps to reproduce the issue:
What did you expect to happen?
a newer installed package is overwritten by an older version by pak:
I would expect that a package is not installed when it has an "older" version number.
The text was updated successfully, but these errors were encountered: