Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r_process subclass shouldn't be cloneable #284

Open
ElianHugh opened this issue Jun 4, 2024 · 1 comment · May be fixed by #289
Open

r_process subclass shouldn't be cloneable #284

ElianHugh opened this issue Jun 4, 2024 · 1 comment · May be fixed by #289
Labels
tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day

Comments

@ElianHugh
Copy link

Since upgrading to R 4.4, I've been having a warning pop up every time I try to use callr::r_bg. I suspect it's a result of me updating R6 -- perhaps a change in R6 at some point changed cloning rules or warning behaviour?

callr::r_bg(\() {})
#> Superclass process has cloneable=FALSE, but subclass r_process has cloneable=TRUE. A subclass cannot be cloneable when its superclass is not cloneable, so cloning will be disabled for r_process.
#> PROCESS 'R', running, pid 187359.

Created on 2024-06-04 with reprex v2.1.0.9000

Very small bug, but it can be annoying when logging or testing to be spammed with the R6 warning. I think the solution would be to change the r_process class to explicitly say cloneable=FALSE, though I'm surprised that cloning behaviour isn't implicitly inherited.

@gaborcsardi
Copy link
Member

I don't think this happens with the released version of R6, but yeah, we should change it.

@gaborcsardi gaborcsardi added the tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day label Jul 17, 2024
@karawoo karawoo linked a pull request Aug 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tidy-dev-day 🤓 Tidyverse Developer Day rstd.io/tidy-dev-day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants