Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency handling #101

Merged
merged 2 commits into from
Jun 9, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@

# pkgsearch 3.0.2.9000

* Fix dependency handling in the add-in (@salim-b, #101)

# pkgsearch 3.0.2

* The RStudio addin now gives a better error more missing dependencies
Expand Down
4 changes: 2 additions & 2 deletions R/addin.R
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ pkg_search_addin <- function(
query = "",
viewer = c("dialog", "browser")) {

needs_packages(c("memoise", "shiny", "shinyjs", "shinyWidgets", "whoami"))

query
maint <- whoami::email_address(fallback = "")

Expand All @@ -48,8 +50,6 @@ pkg_search_addin <- function(
`cnt-maint-next` = 0L
)

needs_packages(c("memoise", "shiny", "shinyjs", "shinyWidgets", "whoami"))

if (is.character(viewer)) {
mode <- match.arg(viewer)
if (mode == "dialog") {
Expand Down