Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

[FEATURE] Optimize for termux #23

Open
4 of 5 tasks
DhruvaSambrani opened this issue Aug 26, 2021 · 4 comments
Open
4 of 5 tasks

[FEATURE] Optimize for termux #23

DhruvaSambrani opened this issue Aug 26, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@DhruvaSambrani
Copy link
Contributor

DhruvaSambrani commented Aug 26, 2021

Starting a discussion to optimize for termux

The following are my opinions

UI Changes

  • Reorder layout to have feeds tab above the article tab, and display only current feed name
  • Do not display time and reduce whitespace in feed title

Behavior changes

  • Add --minimal command line option to activate "termux mode"
  • Add tab and shift-tab to change feed Add PGUP and PGDN to change feed
  • Reload screen size on terminal resize (Needed as keyboard can be closed after running neix)
@DhruvaSambrani DhruvaSambrani added the enhancement New feature or request label Aug 26, 2021
@qw3rtty qw3rtty self-assigned this Aug 26, 2021
@qw3rtty qw3rtty added the help wanted Extra attention is needed label Aug 26, 2021
@DhruvaSambrani
Copy link
Contributor Author

#18 has some thing on keybindings. Should that be implemented first?
Then termux keybindings will work as usual

@DhruvaSambrani
Copy link
Contributor Author

Note that resizing is already supposed to work, but requires an extra keypress post resizing. This is a quirk of the ncurses library, and we can't do much.

Further, presently the resize is handled by KEY_RESIZE, but according to an SO post, not all ncurses are compiled with that enabled. In order to avoid this, we can either handle the signal ourselves, or, more simply, add a keybinding r to force resize.

@DhruvaSambrani
Copy link
Contributor Author

PGUP and PGDN should change feed, not tab and shift-tab as those are the ones shown by default.

@DhruvaSambrani
Copy link
Contributor Author

#28 should complete all tasks except adding a command line configuration. Instead, it uses screen width as a heuristic for portrait orientation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants