Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mcsolve performance #265

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Conversation

albertomercurio
Copy link
Member

Description

This PR improves the performance of mcsolve. This changes the way to compute which collapse operator is acting of the state. To do this, I preallocate the list of hermitian collapse operators $\hat{C}^\dagger \hat{C}$, making much easier to compute $\langle \psi \vert \hat{C}^\dagger \hat{C} \vert \psi \rangle$.

I already see some performance improvement in the benchmarks, and I expect more improvements when the initialization overhead is much less than the integration time.

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.79%. Comparing base (110c2e5) to head (c6f9138).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
- Coverage   93.40%   92.79%   -0.61%     
==========================================
  Files          31       31              
  Lines        2334     2331       -3     
==========================================
- Hits         2180     2163      -17     
- Misses        154      168      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertomercurio albertomercurio merged commit 5e94453 into qutip:main Oct 13, 2024
12 of 14 checks passed
albertomercurio added a commit to albertomercurio/QuantumToolbox.jl that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants