Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] onError hook error ignore #52

Open
fatelei opened this issue Aug 19, 2022 · 4 comments
Open

[Discussion] onError hook error ignore #52

fatelei opened this issue Aug 19, 2022 · 4 comments

Comments

@fatelei
Copy link

fatelei commented Aug 19, 2022

i add onError hook, add collect driver.ErrSkip error, how about add error check before call onError

@qustavo
Copy link
Owner

qustavo commented Aug 21, 2022

you mean that onErorr hook is being called with a driver.ErrSkip error?

@fatelei
Copy link
Author

fatelei commented Aug 21, 2022

yes, so i want to submit a pr to ignore this error

@qustavo
Copy link
Owner

qustavo commented Aug 21, 2022

although sounds reasonable, it will break the API.
Please go ahead and create the PR, and let other ppl review it.

@fatelei
Copy link
Author

fatelei commented Aug 21, 2022

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants