Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectionError() should not bring LoginDialog #26

Closed
KitsuneRal opened this issue Sep 8, 2016 · 0 comments
Closed

connectionError() should not bring LoginDialog #26

KitsuneRal opened this issue Sep 8, 2016 · 0 comments
Labels
enhancement A feature or change request for the library

Comments

@KitsuneRal
Copy link
Member

We should only show a login dialog in cases when we're certain there's a problem with access_token. Right now it is shown on any error from PasswordLogin job, which in turn is invoked every time when SyncJob has problems (by means of Connection::reconnect()).

Speaking of Connection::reconnect(), I wonder if it even should exist in its current form. Storing a password even in memory is not a very good thing. The protocol mandates usage of refresh_tokens to get a new access_token - probably that's what is supposed to be in there. And even that should only be used in case when access_token becomes invalid, not for all cases of access denial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature or change request for the library
Projects
None yet
Development

No branches or pull requests

1 participant