Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backspace at the header beginning should keep the format #3013

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

luin
Copy link
Member

@luin luin commented Apr 20, 2020

Currently, press backspace at the beginning of a header clears the header format even if the previous line is empty.

To reproduce

  1. In an empty editor, press the enter key to create a new line.
  2. Enter some text and set the line as a header.
  3. Place the cursor at the beginning of the line.
  4. Press backspace.

Actual

The header format is lost.

Expected

The header format should be kept. In contrast, if the previous line is not empty (either it has content or it is set a block format like { header: 2 }).


Test plan

Follow the reproduce steps, make sure the result is what mentioned in the expected section above.

@jhchen jhchen merged commit 676816a into slab:develop Apr 20, 2020
@luin luin deleted the backspace-begining branch April 21, 2020 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants