logo: transliterate windows paths to urls

Author: gordonwoodhull

src/format/dashboard/format-dashboard.ts

@@ -130,11 +130,26 @@ export function dashboardFormat() {
             alt: format.metadata[kLogoAlt] as string,
           };
         }
-        format.metadata[kLogo] = resolveLogo(brand, logoSpec, [
+        const resolvedLogo = resolveLogo(brand, logoSpec, [
           "small",
           "medium",
           "large",
         ]);
+        if (resolvedLogo) {
+          if (resolvedLogo.light) {
+            resolvedLogo.light.path = resolvedLogo.light.path.replaceAll(
+              "\\",
+              "/",
+            );
+          }
+          if (resolvedLogo.dark) {
+            resolvedLogo.dark.path = resolvedLogo.dark.path.replaceAll(
+              "\\",
+              "/",
+            );
+          }
+        }
+        format.metadata[kLogo] = resolvedLogo;
 
         const extras: FormatExtras = await baseHtmlFormat.formatExtras(
           input,

src/project/types/website/website-navigation.ts

@@ -1516,11 +1516,11 @@ async function sidebarTitle(sidebar: Sidebar, project: ProjectContext) {
 }
 
 function resolveLogo(logo?: string) {
-  if (logo && !isExternalPath(logo) && !logo.startsWith("/")) {
-    return "/" + logo;
-  } else {
-    return logo;
+  if (!logo || isExternalPath(logo)) {
+    return logo; // TODO: what about urls on windows? https://github.com/quarto-dev/quarto-cli/issues/12643
   }
+  logo = logo.replaceAll("\\", "/"); // windows path to url
+  return logo.startsWith("/") ? logo : "/" + logo;
 }
 
 async function websiteHeadroom(project: ProjectContext) {

tests/docs/smoke-all/brand/logo/logo-extension/test.qmd

@@ -3,10 +3,7 @@ title: test brand extension
 format:
   html: default
   dashboard: default
-# ERROR: NotFound: No such file or directory (os error 2): rename
-# '/Users/gordon/src/quarto-cli/tests/docs/smoke-all/brand/logo/logo-extension/test.html' ->
-# '/Users/gordon/src/quarto-cli/tests/docs/smoke-all/brand/logo/logo-extension/_site/test.html'
-#  revealjs: default
+  revealjs: default
   typst:
     output-ext: typ
 _quarto:
@@ -23,6 +20,11 @@ _quarto:
           - 'img[src="site_libs/quarto-contrib/quarto-project/my-brand/sun-face.png"][alt="sun face"][class="navbar-logo light-content d-inline-block"]'
           - 'img[src="site_libs/quarto-contrib/quarto-project/my-brand/moon-face.png"][alt="moon face"][class="navbar-logo dark-content d-inline-block"]'
         - []
+    revealjs:
+      ensureHtmlElements:
+        -
+          - 'img[src="revealjs-dark-logo.png"][alt="sun face"]'
+        - []
     typst:
       ensureTypstFileRegexMatches:
         -