-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pupil aiming with tilted object #8
Comments
The above code tries to evaluate a 4f system from a tilted plane to a tilted plane. Obviously something is wrong here, probably I entered bad parameters. But the stop should be plane 5, although the bundle diameter is still according to the stop, the rays do not pass through it. The marginal and chief rays seem fine. So there is possible an aiming issue? |
Indeed , when
is executed for stop=5 the brentq solver in aim_marginal does throw an error. Although a paraxial marginal ray is clearly found. |
Yes. This is incomplete/a bug. |
Oh and I don't like it sprinkling the |
Yes, it is Python 2.X . Are you using new language features? Apart from this, everything seemed to run fine. I guess by dropping all aiming tracing a given set of rays via geometric_ray.propagate(clip=True) will work correctly even for a tilted object plane. |
True. You can always use |
Please, say if you are tired of these discussions. I know much less about these matters and how ray tracing packages usually operate. Wouldn't it be ok to aim from the non tilted plane and tilt the aimed rays with |
You can have other elements offset and tilted on the way from the object to the stop. Therefore you can just as well aim in the fully tilted configuration. Yes. uniform angular distributions are correct for some cases. But other cases need |
The text was updated successfully, but these errors were encountered: