Fix Amazon Lambda handler discovery fallback #49611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 52ba3d5.
Add fallback to use root implementor when no matching handleRequest method is found in the class hierarchy. Closes quarkusio#49413
zakkak
commented
Aug 19, 2025
| .build()); | ||
| } else { | ||
| // Fall back to the root implementor if a matching `handleRequest` is not found in the class hierarchy | ||
| ret.add(new AmazonLambdaBuildItem(lambda, cdiName, streamHandler)); |
Contributor
Author
There was a problem hiding this comment.
@gsmet it looks like this addition is enough to handle #49413
I explored the option of removing the !method.parameterType(0).name().equals(DotName.createSimple(Object.class.getName())) check above to make it detect the generic handleRequest method in the abstract class and register it but no matter what I tried I keep getting:
2025-08-19 17:44:06,717 ERROR [io.qua.ama.lam.run.AbstractLambdaPollLoop] (Lambda Thread (TEST)) Failed to run lambda (TEST): jakarta.enterprise.inject.UnsatisfiedResolutionException: No bean found for required type [class io.quarkus.amazon.lambda.deployment.testing.LambdaWithHierarchyTest$AbstractRequestHandler] and qualifiers [[]]
at io.quarkus.arc.impl.InstanceImpl.bean(InstanceImpl.java:288)
at io.quarkus.arc.impl.InstanceImpl.getInternal(InstanceImpl.java:309)
at io.quarkus.arc.impl.InstanceImpl.get(InstanceImpl.java:190)
at io.quarkus.arc.runtime.BeanContainerImpl.beanInstance(BeanContainerImpl.java:28)
at io.quarkus.amazon.lambda.runtime.AmazonLambdaRecorder$1.processRequest(AmazonLambdaRecorder.java:168)
at io.quarkus.amazon.lambda.runtime.AbstractLambdaPollLoop$1.run(AbstractLambdaPollLoop.java:142)
at java.base/java.lang.Thread.run(Thread.java:1583)
geoand
approved these changes
Aug 27, 2025
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handleRequestmethod is found in the class hierarchy.Fixes #49413
cc @gsmet