Config mapping vertx default map #33640
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@radcortez I experimented with the new feature you implemented for default map entries on top of #33228 .
Probably a good idea to drive #33228 before focusing on this new one but I promised you some feedback :).
I confirm that it would be better to have a separate annotation as I had to adjust the config reference doc generation: the semantic is really different, let's have a separate annotation.
And apart from that, I got things to compile but I have a weird issue with the Agroal testing.
When running the tests for Agroal (with
./mvnw -f extensions/agroal/ clean install -Dtest-containers -Dstart-containers) I end up with:which is a bit confusing as
quarkus.datasource.health.enabledis not in a Map, it's at the root ofDataSourcesBuildTimeConfigso there's something odd going on. The error message seems to reference a map entry as it has a*in it:quarkus.datasource.*.health.enabled. Moreover it has a default value.