Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use real looking versions in mocked data for snapshot testing #15172

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Don't use real looking versions in mocked data for snapshot testing #15172

merged 1 commit into from
Feb 19, 2021

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Feb 18, 2021

As requested :)

@quarkus-bot quarkus-bot bot added the area/jbang Issues related to when using jbang.dev with Quarkus label Feb 18, 2021
@ia3andy ia3andy changed the title Don't use real looking version in mocked data for snapshot testing Don't use real looking versions in mocked data for snapshot testing Feb 18, 2021
aloubyansky
aloubyansky approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ia3andy

@ia3andy
Copy link
Contributor Author

ia3andy commented Feb 18, 2021

CC @gsmet

@aloubyansky aloubyansky merged commit a265d43 into quarkusio:master Feb 19, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Feb 19, 2021
@gsmet gsmet modified the milestones: 1.13 - master, 1.12.2.Final Mar 8, 2021
This was referenced Mar 12, 2021
Merged
Closed
Merged
Closed
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Merged
Merged
Merged
This was referenced Mar 12, 2021
Merged
Merged
Merged
Closed
Merged
Closed
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky aloubyansky approved these changes

Assignees
No one assigned
Labels
area/jbang Issues related to when using jbang.dev with Quarkus
Projects
None yet
Milestone
1.12.2.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@ia3andy @aloubyansky @gsmet